Lazy load report images #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@justinph Thanks for the PR -- I have been wanting to see this for a long time! Finally! 😄 I will check this before pushing to NPM -- but before I do I just want to make sure you checked this against |
|
@garris: Yup, it looked all good from the smoke tests. Also ran it against our own configs and it works well, no discernible issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes viewing the generated HTML reports more efficient and user-friendly by not loading test images that are not yet in the viewport. This makes it far more practical to view large reports quickly and not have the page consume large amounts of bandwidth.
This change adds and uses react-visibility-sensor to handle the visibility detection. This is the library used on www.nytimes.com to lazily load images.
Note: please ignore the extra early commits in my PR from some earlier work. I assume this will get squash-merged so they won't matter.