Making the scrubber sticky

[jwongnz]

Some files in compare/output/ got changed automatically.

copy-report-bundle script modified to make the html_report directory before trying to copy to it, as that was causing errors.

Also updating some of the build syntax (; -> &&) https://corgibytes.com/blog/2017/04/18/npm-tips/#bailing-out-when-a-command-fails

[garris]

Thanks for this. Could you include a screenshot?

[BBlackwo]

@garris sure thing. Below is a screenshot and also a recording:

[garris]

This is a classy update. Thanks guys! Will publish as soon as I can.

[garris]

Oh, one more request. Sorry. Looks like you have an older version of compare/output/diverged.js. I think if you rebase the issue should go away.

Thanks!

[BBlackwo]

Hey @garris we tried rebasing, and still have the same issue. I believe the issue is the script that copies the diverged script from the npm module:

"build-compare": "cp ./node_modules/diverged/src/diverged.js ./compare/output/ ..."

Might have something to do with commit 6e6b839 and/or commit d8a930a where you updated the diverged dependency and the output/diverged.js file.

So as far as I can tell, there's a difference between ./node_modules/diverged/src/diverged.js and what was checked in under ./compare/output/ -- and we've just done a fresh npm install, so it seems the issue is the version of diverged in the package-lock.json.

So we can revert our changed files, but the next time someone does an npm install and then runs build-compare the change will come back.

[garris]

@BBlackwo ah, you are correct! My bad. I'll deal with it. You are cleared for takeoff. 😉