swap! #3
swap! #3
Conversation
| @test findfirst(original, "dog") == 2 | ||
| end | ||
|
|
||
|
|
There was a problem hiding this comment.
Thanks! Can you switch to a four-space indent and also get rid of the added newline at the end of the file?
I think it would also be good to have a test for when to == from. Perhaps the function itself should special-case for this and return immediately as well.
|
Sure ;) You're welcome! |
| export AbstractIndexedArray, IndexedArray, IndexedArrayError, findfirst! | ||
| "`swap!(ia::IndexedArray, to::Int, from::Int)` interchange/swap the values on the indices `to` and `from` in the `IndexedArray`" | ||
| function swap!(ia::IndexedArray, to::Int, from::Int) | ||
| if to == from && checkbounds(ia,to) |
There was a problem hiding this comment.
Actually, I would have put the checkbounds as the first line inside the if block, not as part of the conditional, which is how it is typically done. It is interesting that the current code also works correctly though, which has led me to file JuliaLang/julia#13334
There was a problem hiding this comment.
Ok, now it's outside the the conditional.
|
Can you squash to a single commit please? |
|
Squashed ;) |
|
Thanks! |
|
You're welcome |
This adds a
swap!function for interchange elements on theIndexedArray