update use of Component_.name to account for dollar signs in the name #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for investigating this and having submited a pr |
renovate bot
referenced
this pull request
in Unleash/unleash
Oct 30, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [tss-react](https://www.tss-react.dev) ([source](https://togithub.com/garronej/tss-react)) | [`4.9.2` -> `4.9.3`](https://renovatebot.com/diffs/npm/tss-react/4.9.2/4.9.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>garronej/tss-react (tss-react)</summary> ### [`v4.9.3`](https://togithub.com/garronej/tss-react/releases/tag/v4.9.3) [Compare Source](https://togithub.com/garronej/tss-react/compare/v4.9.2...v4.9.3) <!-- Release notes generated using configuration in .github/release.yaml at refs/heads/main --> #### What's Changed ##### Other Changes - update use of Component\_.name to account for dollar signs in the name by [@​rlansky-percipient](https://togithub.com/rlansky-percipient) in [https://github.com/garronej/tss-react/pull/200](https://togithub.com/garronej/tss-react/pull/200) #### New Contributors - [@​rlansky-percipient](https://togithub.com/rlansky-percipient) made their first contribution in [https://github.com/garronej/tss-react/pull/200](https://togithub.com/garronej/tss-react/pull/200) **Full Changelog**: garronej/tss-react@v4.9.2...v4.9.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Unleash/unleash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run into an issue where, during our production builds, occasionally a Component name will contain a
$at the front. Names like$a, or$bwill sometimes occur. When this happens, the classname applied will then contain a$, which is not a legal value in CSS. The result is that the styles do not get correctly applied to the component. While this doesn't happen often, when it does occur, the consequence are pretty severe.The change in this PR resolves that issue by replacing the
$s in the usage ofComponent_.namewith the stringusd. I have confirmed that this does resolve the issue in our production build in case where it was previously not working.I did not create a Github issue for this because I was unable to come up with a repeatable failure case that did not involve our entire code base.