fix(ObserveViewport): don't waist time with rerender if nothing will …

…be rendered anyhow
garthenweb · Oct 27, 2018 · d0ca819 · d0ca819
1 parent 9853706
commit d0ca819
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/lib/ObserveViewport.tsx b/lib/ObserveViewport.tsx
@@ -68,10 +68,6 @@ export default class ObserveViewport extends React.Component<IProps, IState> {
     };
   }
 
-  shouldComponentUpdate(nextProps: IProps) {
-    return Boolean(nextProps.children);
-  }
-
   componentWillUnmount() {
     if (this.removeViewportChangeListener) {
       this.removeViewportChangeListener(this.handleViewportUpdate);
@@ -95,9 +91,11 @@ export default class ObserveViewport extends React.Component<IProps, IState> {
       this.props.onUpdate(nextViewport, layoutSnapshot);
     }
 
-    this.tickId = raf(() => {
-      this.setState(nextViewport);
-    });
+    if (this.props.children) {
+      this.tickId = raf(() => {
+        this.setState(nextViewport);
+      });
+    }
   };
 
   get optionNotifyScroll(): boolean {