Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Reuse ViewportProvider that are already in the stack #3

Closed
garthenweb opened this issue Sep 1, 2018 · 0 comments
Closed

Feature: Reuse ViewportProvider that are already in the stack #3

garthenweb opened this issue Sep 1, 2018 · 0 comments

Comments

@garthenweb
Copy link
Owner

To reduce stress on the JS thread in case that multiple ViewportProvider are rendered on the same page they should delegate the state instead of reinitializing event listeners and observers.

This can especially come in handy when the provider is used within different libraries.

Note: Might require to add the version to detect whether the providers are compatible with each other.
garthenweb added a commit that referenced this issue Oct 7, 2018
@garthenweb
feat(ObserveViewport): use most outer ViewportProvider
2cbecba 
In case multiple ViewportProviders are renderd within the same
page only the most outer provider should collect scroll and
dimension updates to to reduce duplicate work.

Issue: #3
garthenweb added a commit that referenced this issue Oct 7, 2018
@garthenweb
feat(*): export a version
4611fa8 
The version is currently no used but can be used in
the future to check for compatibility when ViewportProviders
with different versions are rendered within the same tree.
Therefore it is required to introduce it now.

Issue: #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@garthenweb