Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove yarn.lock from publish files #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

styfle
Copy link

@styfle styfle commented Apr 18, 2022

This was already ignored in .npmignore but was still published to npm due to files in package.json

This was already ignored in `.npmignore` but was still published to npm due to `files` in package.json
@lfarrel6
Copy link

lfarrel6 commented Jun 9, 2022

Is there any timeline on when this can be merged and included in a release?

The yarn.lock being included in the released package incorrectly triggers vulnerability scanners.

@styfle
Copy link
Author

styfle commented Jun 9, 2022

cc @garycourt

@MFTabriz
Copy link

MFTabriz commented Jul 6, 2022

I have complained about this to my poor colleague without knowing it’s your package that’s shipping this. You owe him an apology! 😉

@jorrit
Copy link

jorrit commented Oct 10, 2022

I think the entire files section can be removed. Most files it mentions are always included in the NPM package, even when not specified. Also, as this bug demonstrates, having .npmignore and files is confusing.

@prajwalmr62
Copy link

@garycourt can this be merged? We are also facing issues with vulnerability scanners due to this lock file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants