Mangata dev v0.9.36

[devdanco]

No description provided.

[mateuszaaa]

i see a lot of minor modifications that are result of bad formatting or not sure what. Could you try get rid of them so the diff against substrate/polkadot-v0.9.36 will only contain actual modifications we introduced.

 ~/substrate  mangata-dev-v0.9.36 *40 ?2  git diff substrate/polkadot-v0.9.36 --stat
 .github/workflows/burnin-label-notification.yml                              |   17 -
 .github/workflows/mangata-dev.yml                                            |   77 +++
 .github/workflows/mlc_config.json                                            |    7 -
 .github/workflows/release-bot.yml                                            |   18 -
 .github/workflows/trigger-review-pipeline.yml                                |   20 -
 Cargo.lock                                                                   | 4462 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------------------------------------------
 Cargo.toml                                                                   |  356 +++++++++++++-
 bin/node-template/runtime/Cargo.toml                                         |    6 +-
 bin/node/runtime/src/lib.rs                                                  |    3 +-
 client/authority-discovery/src/worker/tests.rs                               |    2 +-
 client/basic-authorship-ver/Cargo.toml                                       |   40 ++
 client/basic-authorship-ver/README.md                                        |   31 ++
 client/basic-authorship-ver/src/basic_authorship.rs                          | 1143 +++++++++++++++++++++++++++++++++++++++++++
 client/basic-authorship-ver/src/lib.rs                                       |  193 ++++++++
 client/basic-authorship/Cargo.toml                                           |    1 +
 client/beefy/Cargo.toml                                                      |    2 +-
 client/beefy/rpc/Cargo.toml                                                  |    2 +-
 client/beefy/rpc/src/lib.rs                                                  |    8 +-
 client/beefy/rpc/src/notification.rs                                         |    2 +-
 client/beefy/src/communication/gossip.rs                                     |    4 +-
 client/beefy/src/communication/request_response/incoming_requests_handler.rs |    2 +-
 client/beefy/src/communication/request_response/outgoing_requests_engine.rs  |    2 +-
 client/beefy/src/import.rs                                                   |    2 +-
 client/beefy/src/justification.rs                                            |   10 +-
 client/beefy/src/keystore.rs                                                 |    4 +-
 client/beefy/src/lib.rs                                                      |    8 +-
 client/beefy/src/round.rs                                                    |    8 +-
 client/beefy/src/tests.rs                                                    |   16 +-
 client/beefy/src/worker.rs                                                   |   12 +-
 client/block-builder-ver/Cargo.toml                                          |   35 ++
 client/block-builder-ver/README.md                                           |    9 +
 client/block-builder-ver/src/lib.rs                                          |  552 +++++++++++++++++++++
 client/consensus/aura/src/lib.rs                                             |    8 +
 client/consensus/babe/src/lib.rs                                             |    8 +
 client/consensus/babe/src/tests.rs                                           |    2 +
 client/consensus/slots/Cargo.toml                                            |    3 +
 client/consensus/slots/src/lib.rs                                            |   54 ++-
 client/finality-grandpa/src/communication/gossip.rs                          |   10 +-
 client/merkle-mountain-range/Cargo.toml                                      |    2 +-
 client/merkle-mountain-range/src/lib.rs                                      |    2 +-
 client/network/bitswap/src/lib.rs                                            |    5 +-
 client/offchain/src/lib.rs                                                   |   12 +
 client/rpc/src/chain/tests.rs                                                |    8 +
 client/service/Cargo.toml                                                    |    2 +
 client/service/src/client/client.rs                                          |   47 ++
 client/service/test/src/client/mod.rs                                        |    2 +
 client/state-db/src/lib.rs                                                   |    5 +-
 client/transaction-pool/src/lib.rs                                           |   21 +-
 frame/assets/src/weights.rs                                                  |    4 +-
 frame/aura/Cargo.toml                                                        |    2 +-
 frame/authorship/Cargo.toml                                                  |    2 +-
 frame/babe/src/benchmarking.rs                                               |   23 +-
 frame/bags-list/remote-tests/Cargo.toml                                      |    3 +-
 frame/bags-list/remote-tests/src/migration.rs                                |    2 +-
 frame/bags-list/remote-tests/src/snapshot.rs                                 |    2 +-
 frame/bags-list/remote-tests/src/try_state.rs                                |    2 +-
 frame/beefy-mmr/Cargo.toml                                                   |    4 +-
 frame/beefy-mmr/primitives/Cargo.toml                                        |    4 +-
 frame/beefy-mmr/primitives/src/lib.rs                                        |    2 +-
 frame/beefy-mmr/src/lib.rs                                                   |   22 +-
 frame/beefy-mmr/src/mock.rs                                                  |    6 +-
 frame/beefy-mmr/src/tests.rs                                                 |    4 +-
 frame/beefy/Cargo.toml                                                       |    4 +-
 frame/beefy/src/lib.rs                                                       |    6 +-
 frame/beefy/src/mock.rs                                                      |    2 +-
 frame/beefy/src/tests.rs                                                     |    2 +-
 frame/benchmarking/Cargo.toml                                                |    1 +
 frame/collective-mangata/Cargo.toml                                          |   50 ++
 frame/collective-mangata/README.md                                           |   25 +
 frame/collective-mangata/src/benchmarking.rs                                 |  644 ++++++++++++++++++++++++
 frame/collective-mangata/src/lib.rs                                          | 1282 ++++++++++++++++++++++++++++++++++++++++++++++++
 frame/collective-mangata/src/migrations/mod.rs                               |   19 +

could you check if you can get rid of them, that would simplify the review process.

example 1

 ~/substrate  mangata-dev-v0.9.36 *40 ?2  git diff substrate/polkadot-v0.9.36 -- client/beefy/rpc/src/notification.rs
diff --git a/client/beefy/rpc/src/notification.rs b/client/beefy/rpc/src/notification.rs
index a815425644d..b03281a23bf 100644
--- a/client/beefy/rpc/src/notification.rs
+++ b/client/beefy/rpc/src/notification.rs
@@ -23,7 +23,7 @@ use sp_runtime::traits::Block as BlockT;
 
 /// An encoded finality proof proving that the given header has been finalized.
 /// The given bytes should be the SCALE-encoded representation of a
-/// `beefy_primitives::VersionedFinalityProof`.
+/// `sp_beefy::VersionedFinalityProof`.
 #[derive(Clone, Serialize, Deserialize)]
 pub struct EncodedVersionedFinalityProof(sp_core::Bytes);

example 2

 ~/substrate  mangata-dev-v0.9.36 *40 ?2  git diff substrate/polkadot-v0.9.36 -- client/network/bitswap/src/lib.rs
diff --git a/client/network/bitswap/src/lib.rs b/client/network/bitswap/src/lib.rs
index 62a18b18c83..3b26c56e7ed 100644
--- a/client/network/bitswap/src/lib.rs
+++ b/client/network/bitswap/src/lib.rs
@@ -127,8 +127,9 @@ impl<B: BlockT> BitswapRequestHandler<B> {
                                        };
 
                                        match pending_response.send(response) {
-                                               Ok(()) =>
-                                                       trace!(target: LOG_TARGET, "Handled bitswap request from {peer}.",),
+                                               Ok(()) => {
+                                                       trace!(target: LOG_TARGET, "Handled bitswap request from {peer}.",)
+                                               },
                                                Err(_) => debug!(
                                                        target: LOG_TARGET,
                                                        "Failed to handle light client request from {peer}: {}",

[mateuszaaa]

looks like there are still some customly formatted files comparing to origin parity impl
frame/support/test/tests/derive_no_bound.rs
frame/support/procedural/src/pallet/expand/storage.rs

[mateuszaaa]

lgtm, just make sure that ci passes