-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect results? #10
Comments
@gatagat - fyi, there is also related discussion in src-d/lapjv#3. |
@ben-eysenbach I think you are not interpreting the results correctly. The returned values are different because of the different representation of assignments. SciPy's lap's If you have an idea how to make this clearer in the docs, let me know. Now it reads:
|
@gatagat - Thanks for the clarification! Here's one alternative way this could be explained in the function docstring:
Here's some discussion that might be helpful in the documentation/readme: The function Note that this function does not return the assignment matrix (as done by scipy's
Equivalently, we could construct the assignment matrix from
Finally, note that the outputs are redundant: we can construct
|
@ben-eysenbach Cool, can you put this into a PR? |
Sure! |
Thanks! |
chore: strict upper bound for numpy 2.0
It appears that this library sometimes returns incorrect results. The example below shows two failure cases. For both problem instances, this library incorrectly assigns both rows to the same column. For reference, I have also included the (presumably correct) results returned by the scipy implementation.
Result
Please let me know if I'm using the library incorrectly, or if there are certain types of inputs to avoid.
The text was updated successfully, but these errors were encountered: