Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to Git packages with "https" (yarnpkg/yarn#4734) #133

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

tuukka
Copy link
Collaborator

@tuukka tuukka commented May 4, 2020

Without this, Yarn uses a version from its cache instead of the
version specified in yarn.lock.

Solution: "specifying it as user/repo#SHA does not update as expected
(more details below), but specifying as
https://github.com/user/repo.git#SHA does work as expected."

yarnpkg/yarn#4722 (comment)

@tuukka tuukka force-pushed the fix/yarn-bug-workaround branch 2 times, most recently from 3e2d961 to 1083746 Compare May 4, 2020 17:35
@github-actions
Copy link

github-actions bot commented May 4, 2020

https://5eb053ec0af5a57b04e69301--boring-ramanujan-de6e24.netlify.app has the deployment for the merge commit 78a586993e663107c3b5807caa0a74d6f31814d1 corresponding to the pull request HEAD commit 1083746bc3a168ed4ad7adea54cf88ef94d9a90a.

@tuukka tuukka requested a review from haphut May 4, 2020 17:54
@tuukka tuukka changed the title Refer to Git packages with "https" (yarnpkg/yarn#4734) WIP: Refer to Git packages with "https" (yarnpkg/yarn#4734) May 22, 2020
@tuukka tuukka force-pushed the fix/yarn-bug-workaround branch from 1083746 to dc3c77d Compare June 1, 2020 07:24
@github-actions
Copy link

github-actions bot commented Jun 1, 2020

https://5ed4aeb058c05261afc1619b--boring-ramanujan-de6e24.netlify.app has the deployment for the merge commit 34dcc8e05c183177d59d90526719fb2cbe441b20 corresponding to the pull request HEAD commit dc3c77d3a976ba5c2b114eb7cf734899610a99d9.

@tuukka tuukka changed the title WIP: Refer to Git packages with "https" (yarnpkg/yarn#4734) Refer to Git packages with "https" (yarnpkg/yarn#4734) Jun 1, 2020
@github-actions
Copy link

github-actions bot commented Jun 1, 2020

The Lighthouse report for the draft URL: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1590996826944-36988.report.html

The Lighthouse report for the production URL: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1590996827331-54560.report.html

The links might expire after the next 7 days. GitHub Actions workflow artifacts contain more reports that might expire later.

Without this, Yarn uses a version from its cache instead of the
version specified in yarn.lock.

Solution: "specifying it as user/repo#SHA does not update as expected
(more details below), but specifying as
https://github.com/user/repo.git#SHA does work as expected."

yarnpkg/yarn#4722 (comment)
@tuukka tuukka force-pushed the fix/yarn-bug-workaround branch from dc3c77d to b363ec0 Compare June 1, 2020 07:50
@github-actions
Copy link

github-actions bot commented Jun 1, 2020

https://5ed4b4e777d22703e737986e--boring-ramanujan-de6e24.netlify.app has the deployment for the merge commit 325f4341aeb9f3f7f2a885b0e71c99b249a6abdf corresponding to the pull request HEAD commit b363ec09ae48dc4755e6b905cff8a977c9bb9b69.

@github-actions
Copy link

github-actions bot commented Jun 1, 2020

The Lighthouse report for the draft URL: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1590999024448-10590.report.html

The Lighthouse report for the production URL: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1590999024770-97764.report.html

The links might expire after the next 7 days. GitHub Actions workflow artifacts contain more reports that might expire later.

@github-actions
Copy link

github-actions bot commented Jun 1, 2020

Draft URL Time to Interactive (TTI) values are 8534, 8584, 8605, 8783, 8979, 9545, 9749, 12309, 20031, 23054, 23192, 23677, 23853, 24647, 25784 ms.

Production URL Time to Interactive (TTI) values are 8910, 9039, 9105, 9261, 10126, 20612, 21104, 21207, 21581, 22340, 23391, 23795, 23920, 24010, 24706 ms.

The change of median value was -42.0 %. Possibly statistically insignificant yay!

@haphut haphut merged commit 2eb03dd into master Jun 1, 2020
@haphut haphut deleted the fix/yarn-bug-workaround branch June 1, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants