Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aktuelt): minimal viable info pages #10

Merged
merged 8 commits into from
Dec 17, 2023
Merged

feat(aktuelt): minimal viable info pages #10

merged 8 commits into from
Dec 17, 2023

Conversation

niccofyren
Copy link
Member

Closes: #8

Similar to (and extending) #9 this PR exposes pages on http://localhost:8000/api/v2/info with semi-realistic fields.

More details in previous PR, but a few additional questions

  • How to best expose a tree of pages via API? It seems like Wagtail expect to mostly list a single level at a time, unless using relational fields (outside of basic page model) or manually listing fields. First option introduces a separate structure level that we don't want, and second option seems to require us to have duplicate serialization logic. One clean (but inefficient) option would be to list types and ids and leave it to frontend code to get actual objects.

@niccofyren niccofyren changed the base branch from main to v1-news-pages December 3, 2023 14:31
Base automatically changed from v1-news-pages to main December 5, 2023 17:28
@niccofyren niccofyren marked this pull request as ready for review December 5, 2023 17:44
@niccofyren niccofyren requested a review from a team as a code owner December 5, 2023 17:44
@niccofyren niccofyren merged commit 851e2a6 into main Dec 17, 2023
5 checks passed
@niccofyren niccofyren deleted the v1-info-pages branch December 17, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Praktisk info section
1 participant