Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Google Storage URLs in input files. #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

willsu
Copy link

@willsu willsu commented Mar 19, 2020

The Google Cloud Storage bucket URL has migrated from gs://broad-references/ to gs://genomics-public-data/references. This PR replaces all references of the old gs:// URL with the new gs:// URL.

The motivation for this change came from some errors received when I was running through the https://cloud.google.com/life-sciences/docs/tutorials/gatk tutorial. This tutorial should be updated to use non-deprecated repositories, but this is an easy fix to correct the Google Storage URLs in the meantime. The tutorial steps ran cleanly after I applied this fix to my local code base.

Thanks for your help and continued maintenance of this repo!

@willsu
Copy link
Author

willsu commented Mar 19, 2020

Interesting, it looks like @bshifaw committed a fix just as I was opening this PR. The main difference was that the base URL of gs://gcp-public-data--broad-references was used instead of gs://genomics-public-data/references. I have only tested with the latter, but I did some quick spot checking and it appears that both URLs will work just fine. I'll leave it up to the maintainers to either close this PR or adopt the gs://genomics-public-data/references URL if they prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant