fix(gatsby-source-strapi): Fix "locale=all" i18n feature for Single Types and Collection Types #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I am interested with it ! |
Contributor
|
I suggest you and @SylvainGibert work together on this (#521). This needs extensive edge case testing, also for non-i18n setups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The linked issue seems to occur because, in Strapi, localized entries share the same documentId, so localized entries override each other when the plugin sources them from Strapi. This is fixed by providing entry.locale (if present) to the
createNodeIdcall.Additionally, this pull request also fixes the handling of
locale=allin queries. For collection types, it appears thatlocale=*still works to fetch all entries of all localizations in Strapi v5, so I stuck with that for now...I have tested this in my application with Strapi v4 & v5, both compiling without problems. I have not tested the new code for an application not using i18 though.
Documentation
https://github.com/gatsby-uc/plugins/blob/main/packages/gatsby-source-strapi/README.md#internationalization This documentation should likely change... please correct me if I overlooked something, but there are no mentions of Strapi v5's breaking changes here. Was a bit confusing, maybe that should be amended in the meantime until these changes are merged?
Anyway, I don't think this documentation needs to change for now, with my changes in mind.
Related Issues
Fixes #509