Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated the adding-form to Hindi #59

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

imrishabh18
Copy link

No description provided.

Copy link
Contributor

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start.

Added review till line 14. Once those are fixed. wewill go to rest of the file review

docs/docs/adding-forms.md Outdated Show resolved Hide resolved
docs/docs/adding-forms.md Outdated Show resolved Hide resolved
docs/docs/adding-forms.md Outdated Show resolved Hide resolved
docs/docs/adding-forms.md Outdated Show resolved Hide resolved

Start with the following page.
सेुरू करें निम्नलिखित पृष्ठ से.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

सेुरू करें निम्नलिखित पृष्ठ से. => निम्नलिखित पेज से सुरु करें।

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a line break on line 6

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have to add line break at line 6. you have added it at line 7.

add the line break here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have to add line break at line 6. you have added it at line 7.

add the line break here

This is still not fixed

@imrishabh18
Copy link
Author

@arshadkazmi42 Hey, It's been a long time since I have resolved the changes. Mind taking a look ?

@arshadkazmi42
Copy link
Contributor

@imrishabh18 there are two issue in two fixes. can you work on those.

also do not mark comments as resolved. just add the 👍 emoji after fixing. reviewer will review the fix and mark it as resolved

@arshadkazmi42
Copy link
Contributor

arshadkazmi42 commented May 27, 2020

@imrishabh18 those issues are still not fixed. can you have a look at my comments above

i think your resolve merge conflicts commit reverted the fixes.

@imrishabh18
Copy link
Author

@arshadkazmi42 Is this fine now ?

@imrishabh18
Copy link
Author

@arshadkazmi42 Hey, check this once

@arshadkazmi42
Copy link
Contributor

@imrishabh18 there is one more open feedback. can you have a look at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants