Skip to content
This repository has been archived by the owner on Oct 25, 2018. It is now read-only.

no progressive enhancement #10

Open
savolai opened this issue Jul 25, 2016 · 8 comments
Open

no progressive enhancement #10

savolai opened this issue Jul 25, 2016 · 8 comments

Comments

@savolai
Copy link

savolai commented Jul 25, 2016

Hi,
Thanks for your work. Lots of things are screaming design vision here.

I have noscript enabled by default. I got this installed and works fine with JS, but shows a white empty page without JS. Source below for debugging purposes. Ideas?

This seems to be the only starter theme for gatsby that actually looks it has some reasonable defaults for me to start from, so basically this getting this to work is a complete roadblock for me for adopting gatsby, unless I figure this out myself at some point.

`

<title></title><style id="typography.js">/*! normalize.css v4.1.1 | MIT License | github.com/necolas/normalize.css */html{font-family:sans-serif;-ms-text-size-adjust:100%;-webkit-text-size-adjust:100%}body{margin:0}article,aside,details,figcaption,figure,footer,header,main,menu,nav,section,summary{display:block}audio,canvas,progress,video{display:inline-block}audio:not([controls]){display:none;height:0}progress{vertical-align:baseline}[hidden],template{display:none}a{background-color:transparent;-webkit-text-decoration-skip:objects}a:active,a:hover{outline-width:0}abbr[title]{border-bottom:none;text-decoration:underline;text-decoration:underline dotted}b,strong{font-weight:inherit;font-weight:bolder}dfn{font-style:italic}h1{font-size:2em;margin:.67em 0}mark{background-color:#ff0;color:#000}small{font-size:80%}sub,sup{font-size:75%;line-height:0;position:relative;vertical-align:baseline}sub{bottom:-.25em}sup{top:-.5em}img{border-style:none}svg:not(:root){overflow:hidden}code,kbd,pre,samp{font-family:monospace,monospace;font-size:1em}figure{margin:1em 40px}hr{box-sizing:content-box;height:0;overflow:visible}button,input,optgroup,select,textarea{font:inherit;margin:0}optgroup{font-weight:700}button,input{overflow:visible}button,select{text-transform:none}[type=reset],[type=submit],button,html [type=button]{-webkit-appearance:button}[type=button]::-moz-focus-inner,[type=reset]::-moz-focus-inner,[type=submit]::-moz-focus-inner,button::-moz-focus-inner{border-style:none;padding:0}[type=button]:-moz-focusring,[type=reset]:-moz-focusring,[type=submit]:-moz-focusring,button:-moz-focusring{outline:1px dotted ButtonText}fieldset{border:1px solid silver;margin:0 2px;padding:.35em .625em .75em}legend{box-sizing:border-box;color:inherit;display:table;max-width:100%;padding:0;white-space:normal}textarea{overflow:auto}[type=checkbox],[type=radio]{box-sizing:border-box;padding:0}[type=number]::-webkit-inner-spin-button,[type=number]::-webkit-outer-spin-button{height:auto}[type=search]{-webkit-appearance:textfield;outline-offset:-2px}[type=search]::-webkit-search-cancel-button,[type=search]::-webkit-search-decoration{-webkit-appearance:none}::-webkit-input-placeholder{color:inherit;opacity:.54}::-webkit-file-upload-button{-webkit-appearance:button;font:inherit}html{font-size:100%;line-height:1.5em;box-sizing:border-box;overflow-y:scroll;}*{box-sizing:inherit;}*:before{box-sizing:inherit;}*:after{box-sizing:inherit;}body{color:hsl(0,0%,20%);font-family:Helvetica Neue,Segoe UI,Helvetica,Arial,sans-serif;font-weight:300;word-wrap:break-word;}img{max-width:100%;margin:0;padding:0;margin-bottom:1.5rem;}h1{margin:0;padding:0;margin-bottom:1.5rem;color:hsl(0,0%,20%);font-family:Helvetica Neue,Segoe UI,Helvetica,Arial,sans-serif;font-weight:600;text-rendering:optimizeLegibility;font-size:1.61803rem;line-height:2.25rem;}h2{margin:0;padding:0;margin-bottom:1.5rem;color:hsl(0,0%,20%);font-family:Helvetica Neue,Segoe UI,Helvetica,Arial,sans-serif;font-weight:600;text-rendering:optimizeLegibility;font-size:1.46957rem;line-height:2.25rem;}h3{margin:0;padding:0;margin-bottom:1.5rem;color:hsl(0,0%,20%);font-family:Helvetica Neue,Segoe UI,Helvetica,Arial,sans-serif;font-weight:600;text-rendering:optimizeLegibility;font-size:1.33473rem;line-height:2.25rem;}h4{margin:0;padding:0;margin-bottom:1.5rem;color:hsl(0,0%,20%);font-family:Helvetica Neue,Segoe UI,Helvetica,Arial,sans-serif;font-weight:600;text-rendering:optimizeLegibility;font-size:1.21226rem;line-height:1.5rem;}h5{margin:0;padding:0;margin-bottom:1.5rem;color:hsl(0,0%,20%);font-family:Helvetica Neue,Segoe UI,Helvetica,Arial,sans-serif;font-weight:600;text-rendering:optimizeLegibility;font-size:1.10103rem;line-height:1.5rem;}h6{margin:0;padding:0;margin-bottom:1.5rem;color:hsl(0,0%,20%);font-family:Helvetica Neue,Segoe UI,Helvetica,Arial,sans-serif;font-weight:600;text-rendering:optimizeLegibility;font-size:1rem;line-height:1.5rem;}hgroup{margin:0;padding:0;margin-bottom:1.5rem;}ul{margin:0;padding:0;margin-bottom:1.5rem;list-style-position:outside;list-style-image:none;margin-left:1.5rem;}ol{margin:0;padding:0;margin-bottom:1.5rem;list-style-position:outside;list-style-image:none;margin-left:1.5rem;}dl{margin:0;padding:0;margin-bottom:1.5rem;}dd{margin:0;padding:0;margin-bottom:1.5rem;}p{margin:0;padding:0;margin-bottom:1.5rem;}figure{margin:0;padding:0;margin-bottom:1.5rem;}pre{margin:0;padding:0;margin-bottom:1.5rem;font-size:0.85rem;line-height:1.5rem;}table{margin:0;padding:0;margin-bottom:1.5rem;font-size:1rem;line-height:1.5rem;border-collapse:collapse;width:100%;}fieldset{margin:0;padding:0;margin-bottom:1.5rem;}blockquote{margin:0;padding:0;margin-bottom:1.5rem;margin-right:1.5rem;margin-left:1.5rem;}form{margin:0;padding:0;margin-bottom:1.5rem;}noscript{margin:0;padding:0;margin-bottom:1.5rem;}iframe{margin:0;padding:0;margin-bottom:1.5rem;}hr{margin:0;padding:0;margin-bottom:calc(1.5rem - 1px);background:hsl(0,0%,80%);border:none;height:1px;}address{margin:0;padding:0;margin-bottom:1.5rem;}b{font-weight:600;}strong{font-weight:600;}dt{font-weight:600;}th{font-weight:600;}li{margin-bottom:0.75rem;}ol li{padding-left:0;}ul li{padding-left:0;}li > ol{margin-left:1.5rem;margin-bottom:0.75rem;margin-top:0.75rem;}li > ul{margin-left:1.5rem;margin-bottom:0.75rem;margin-top:0.75rem;}code{font-size:0.85rem;line-height:1.5rem;}kbd{font-size:0.85rem;line-height:1.5rem;}samp{font-size:0.85rem;line-height:1.5rem;}abbr{border-bottom:1px dotted hsl(0,0%,50%);cursor:help;}acronym{border-bottom:1px dotted hsl(0,0%,50%);cursor:help;}abbr[title]{border-bottom:1px dotted hsl(0,0%,50%);cursor:help;text-decoration:none;}thead{text-align:left;}td,th{text-align:left;border-bottom:1px solid hsl(0,0%,88%);padding-left:1rem;padding-right:1rem;padding-top:0.75rem;padding-bottom:calc(0.75rem - 1px);}th:first-child,td:first-child{padding-left:0;}th:last-child,td:last-child{padding-right:0;}</style><style> a { color: rgb(136,68,153); } .ball-0 { background-image: url(/docs/some-react-code/0.jpg); } .ball-1 { background-image: url(/docs/some-react-code/1.jpg); } .ball-2 { background-image: url(/docs/some-react-code/2.jpg); } .ball-3 { background-image: url(/docs/some-react-code/3.jpg); } .ball-4 { background-image: url(/docs/some-react-code/4.jpg); } .ball-5 { background-image: url(/docs/some-react-code/5.jpg); } </style>
<script src="/bundle.js?t=1469430420045"></script>`
@KyleAMathews
Copy link
Contributor

Hi which page is showing up white? I just visited the demo version of this w/o JS and things were working e.g. http://gatsbyjs.github.io/gatsby-starter-documentation/docs/getting-started/

@savolai
Copy link
Author

savolai commented Jul 25, 2016

Actually, just realized it's all pages on all gatsby sites when running them on my OS X 10.11.5. I get no error messages though.

@KyleAMathews
Copy link
Contributor

I'm confused... all Gatsby sites? Like the Gatsby sites on gatsbyjs.github.io? There wouldn't be JS errors if JS is disabled. Can you visit the link I posted above with JS disabled? Can you post a screenshot please.

@savolai
Copy link
Author

savolai commented Jul 27, 2016

Sorry , meant all localhost sites using gatsby develop. I also tried the default and blog sites.

@KyleAMathews
Copy link
Contributor

Oh well then that's as expected for localhost. The dev server doesn't
render a static version of the site. Try running "gatsby build; gatsby
serve-build" to see the static version.
On Wed, Jul 27, 2016 at 10:00 AM Olli Savolainen notifications@github.com
wrote:

Sorry , meant all localhost sites using gatsby develop. I also tried the
default and blog sites.


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#10 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEVh1697Vr31T5TpMCtfKV4KcFrah5Jks5qZ46SgaJpZM4JT2DV
.

@savolai
Copy link
Author

savolai commented Jul 28, 2016

Oh, right. Thanks. Perhaps serve a notification that states that fact, instead of empty page, in that situation? Having progressive enhancement seems core functionality of gatsby, so didn't expect it to be missing while developing.

@KyleAMathews
Copy link
Contributor

That's a really good suggestion. Could you create an issue in the main
Gatsby repo for this? I'll get to this soon.

On Thu, Jul 28, 2016 at 11:56 AM Olli Savolainen notifications@github.com
wrote:

Oh, right. Thanks. Perhaps serve a notification that states that fact,
instead of empty page, in that situation?


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#10 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEVhwXFyb2o1U9gxOecv3VfX2a24-0uks5qaPtEgaJpZM4JT2DV
.

@savolai
Copy link
Author

savolai commented Aug 2, 2016

Sure, I'll try to remember to do that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants