Deprecate old deleteNode method signature

gatsbyjs · May 10, 2018 · ab2aa85 · ab2aa85
1 parent 509da90
commit ab2aa85
Show file tree

Hide file tree

Showing 7 changed files with 385 additions and 350 deletions.
diff --git a/packages/gatsby-source-contentful/src/gatsby-node.js b/packages/gatsby-source-contentful/src/gatsby-node.js
@@ -68,8 +68,8 @@ exports.sourceNodes = async (
  // Remove deleted entries & assets.
  // TODO figure out if entries referencing now deleted entries/assets
  // are "updated" so will get the now deleted reference removed.
- currentSyncData.deletedEntries.forEach(e => deleteNode(e.sys))
- currentSyncData.deletedAssets.forEach(e => deleteNode(e.sys))
+ currentSyncData.deletedEntries.forEach(e => deleteNode({ node: e.sys }))
+ currentSyncData.deletedAssets.forEach(e => deleteNode({ node: e.sys }))
 
  const existingNodes = getNodes().filter(
  n => n.internal.owner === `gatsby-source-contentful`

diff --git a/packages/gatsby-source-filesystem/src/gatsby-node.js b/packages/gatsby-source-filesystem/src/gatsby-node.js
@@ -188,7 +188,7 @@ See docs here - https://www.gatsbyjs.org/packages/gatsby-source-filesystem/
  // write and then immediately delete temporary files to the file system.
  if (node) {
  currentState = fsMachine.transition(currentState.value, `EMIT_FS_EVENT`)
- deleteNode(node)
+ deleteNode({ node })
  }
  })
 
@@ -212,7 +212,7 @@ See docs here - https://www.gatsbyjs.org/packages/gatsby-source-filesystem/
  reporter.info(`directory deleted at ${path}`)
  }
  const node = getNode(createNodeId(path))
- deleteNode(node)
+ deleteNode({ node })
  })
 
  return new Promise((resolve, reject) => {

diff --git a/packages/gatsby/src/internal-plugins/internal-data-bridge/gatsby-node.js b/packages/gatsby/src/internal-plugins/internal-data-bridge/gatsby-node.js
@@ -168,5 +168,5 @@ exports.onCreatePage = ({ page, actions }) => {
 emitter.on(`DELETE_PAGE`, action => {
  const nodeId = createPageId(action.payload.path)
  const node = getNode(nodeId)
- boundActionCreators.deleteNode(node)
+ boundActionCreators.deleteNode({ node })
 })
diff --git a/packages/gatsby/src/redux/__tests__/__snapshots__/nodes.js.snap b/packages/gatsby/src/redux/__tests__/__snapshots__/nodes.js.snap
@@ -127,3 +127,16 @@ exports[`Create and update nodes throws error if a node sets a value on "fields"
  \\"name\\": \\"pluginA\\"
 }"
 `;
+
+exports[`Create and update nodes warns when using old deleteNode signature 1`] = `
+Object {
+ "children": Array [],
+ "id": "hi",
+ "internal": Object {
+ "contentDigest": "hasdfljds",
+ "owner": "tests",
+ "type": "Test",
+ },
+ "parent": "test",
+}
+`;