-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Favicons generated by gatsby-plugin-manifest aren't recognized by iOS Safari #10770
Comments
You need to set the |
@LekoArts Thank you for answering! Actually, I thought it was a bug because I'm on iOS 12.1.3, which is over 11.3 (mentioned by the readme of gatsby-plugin-manifest). |
I think the note in the README is kind of wrong. Apple didn't implement the complete spec to my knowledge but only some parts (e.g. the service worker things) and it hasn't changed since 11.3 |
Okay, then I would like to suggest renaming the flag from |
#7256 added a `legacy` flag (defaulting to `false`) to include the apple-touch-icons. However, the assumption was wrong that iOS supports the icons from the webmanifest - they don't. That's why apple-touch-icons are still needed and the default state of `legacy` should be set to `true`. I made those necessary changes. Fixes #10770
Description
When using gatsby-plugin-favicon, iOS Safari recognizes the site's favicon and uses it for bookmarking and adding the page to the home screen.
Steps to reproduce
yarn add gatsby-plugin-manifest
gatsby-config.js
Demo: https://5c2c104adaf1cb0008d6975f--schdesign.netlify.com/
Source code: https://github.com/simonyiszk/schdesign-web/tree/bc38c14281aca0757fb06288a67f1f4de7e7143f
Expected result
Icons generated by gatsby-plugin-manifest should be recognizable by iOS Safari.
Environment
The text was updated successfully, but these errors were encountered: