Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[themes] Component shadowing doesn't resolve properly if multiple themes shadow the same component #11951

Closed
jlengstorf opened this issue Feb 21, 2019 · 0 comments
Labels
status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. type: bug An issue or pull request relating to a bug in Gatsby

Comments

@jlengstorf
Copy link
Contributor

jlengstorf commented Feb 21, 2019

Description

In a theme scenario where there are multiple ancestors, component shadowing appears to only respect the first component (or it stops looking after a certain point).

Example (site uses theme3, theme3 uses theme2, theme2 uses theme1):

=> theme1/src/components/foo.js
=> theme2/src/theme1/components/foo.js (actually shows up)
=> theme3/src/theme1/components/foo.js (should show up)
=> site (where develop is run from)

Steps to reproduce

See this repo: https://github.com/jlengstorf/theme-shadowing-bug

Environment

  System:
    OS: macOS 10.14.3
    CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 10.14.2 - ~/.nvm/versions/node/v10.14.2/bin/node
    Yarn: 1.13.0 - /usr/local/bin/yarn
    npm: 6.4.1 - ~/.nvm/versions/node/v10.14.2/bin/npm
  Languages:
    Python: 2.7.15 - /usr/local/bin/python
  Browsers:
    Chrome: 72.0.3626.109
    Firefox: 63.0
    Safari: 12.0.3
@wardpeet wardpeet added type: bug An issue or pull request relating to a bug in Gatsby status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. labels Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

No branches or pull requests

3 participants