fix(themes): reverse order of themes checked when shadowing #11954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm unsure if we're already at that state but would be cool if we had some unit tests or integration tests for these functionalities. |
jlengstorf
approved these changes
Feb 21, 2019
johno
approved these changes
Feb 21, 2019
|
Looks good to me! @wardpeet it's on @ChristopherBiscardi's radar! Should be coming soon! |
|
|
@wardpeet yep, tests are on my radar. some e2e ones should show up soon to start |
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Component shadowing with a total number of potential shadowings >= 2 (excluding the theme with the component and the site itself, which are absolutely positioned in the order relative to other potential shadow paths) exhibit a bug due to the ordering in which potential theme paths are checked. The order should be reversed. This PR copies the themes array (not strictly necessary, but we shouldn't depend on the assumption that we can safely mutate) then reverses it.
Related Issues
Fixes #11951