-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Plugin repos that aren't appearing in Plugin library #14013
Update Plugin repos that aren't appearing in Plugin library #14013
Comments
Awesome @gillkyle, you're the best! |
Related to #12503 |
Hi! Here are the plugins I have made PRs to (they include some that already included the keywords).
|
Hi! I've just made my first open source pull request in gatsby-plugin-graphql. I will try to hunt another plugins as soon as I get home.
|
we probably want to update our script somehow to check if a repo is archived or not. If anyone wants to update https://github.com/gatsbyjs/gatsby/blob/master/scripts/gatsby-plugin-checker/index.js we would be grateful. |
I would like to take care of it. Should I just create a pull request or are there any other steps I need to take? |
Thanks for the help @ashley and @dmarkiewicz! @dmarkiewicz I would reference the guidelines mentioned in Issue 5211 as well, but then making a pull request that at least checks if the repo is archived like @wardpeet mentioned would be fantastic 🙂 |
@gillkyle I think that checking if repositories are archived require a Github App Token because there is a limit of 60 requests per hour. To check if repository is archived I need to call API for each of them and that might exceed the limit. Is there a possibility to create such token? I think it might be also necessary for creating comments in those repositories. |
Hello 👋 As part of gatsbyjs/gatsby#14013, I would like to add `gatsby` and `gatsby-plugin` keywords to the `package.json` file of your source plugin. It is documented in https://www.gatsbyjs.org/contributing/submit-to-plugin-library/ if you would like to know more about it. If you accept to merge this PR, could you also publish a patch version of your source plugin on NPM? Thank you very much!
Issues created: PRs created:
Repo archived: Misc:
|
Thanks for adding your help on so many of these @RobinCsl! I guess that Netlify lambda plugin must be in a private repo or something. If that's the case they may not want to include it as a plugin in the library but good we've at least made them aware how they can! |
I've opened some PRs for now:
The above already have
|
PRs Created:
Following has gatsby and gatsby-plugin included in keywords already
|
@dmarkiewicz let's just not do it then, api tokens are to much hassle when running it. Another way would be to do a get request to the repo and search for the string but that's just to messy so we'll just deal with it 😎 Thanks for looking into it! |
Thanks for finishing up the last packages @PriyaBhatt13! We've now got PRs and issues filed in all the repos listed, thanks for all the help 🥇 I'll be monitoring the issues here to watch as things (hopefully) get merged in. |
I sent emails to the package authors that haven't been updated yet, encouraging them to merge PR's, several have responded already. |
Hello 👋 As part of gatsbyjs/gatsby#14013, I would like to add gatsby and gatsby-plugin keywords to the package.json file of your source plugin. It is documented in https://www.gatsbyjs.org/contributing/submit-to-plugin-library/ if you would like to know more about it. If you accept to merge this PR, could you also publish a patch version of your source plugin on NPM? Let me know if I can assist in any way with this. 🙂 Thank you very much!
Closing as we've done what we can on our end, many of the remaining plugins aren't being maintained or updated and pull requests have been made that package maintainers have the option of merging. According to the initial list 37 plugins were added to the plugin library so thanks everyone! 👏 |
There are a lot of plugins floating around on repositories that aren't included in the plugin library. Issue #5211 was created to address this, and a lot of progress was made on a script that will find plugins that mention
gatsby-source
,gatsby-plugin
, orgatsby-transformer
and don't match the list from Gatsby's keyword search for plugins to include in the library. However, that issue didn't track fixes to repositories that needed to be updated and the script hasn't been completed to post issues in GitHub repositories.Steps
These packages just need the
gatsby
andgatsby-plugin
keywords included in theirpackage.json
(docs for reference). For each plugin:gatsby
andgatsby-plugin
are included in the keywords section of thepackage.json
Plugins to Update
Running the script lists these packages from npm that should be updated:
(Check marks are added when an issue or PR has been created, they are crossed out when keywords have been merged)
(Update: all repos have had an issue or PR filed, thanks everyone!)
gatsby-plugin-productiongatsby-plugin-purify-cssgatsby-plugin-stripe-elementsgatsby-plugin-indiewebgatsby-plugin-i18n-extensiongatsby-plugin-faviconsgatsby-source-jsonapigatsby-source-twitter-usersgatsby-transformer-geojsongatsby-plugin-polyfill-cdngatsby-source-stripe-productsgatsby-plugin-snowplowgatsby-plugin-protoculturegatsby-plugin-landrgatsby-plugin-ngrok-tunnelinggatsby-source-newsapigatsby-plugin-dripgatsby-source-anilistgatsby-source-github-apigatsby-source-nbagatsby-source-steamgatsby-plugin-netlify-lambdagatsby-plugin-core-jsgatsby-source-github-projectsgatsby-plugin-google-fontsgatsby-source-utopiangatsby-transformer-ipynbgatsby-plugin-module-local-ident-namegatsby-plugin-copy-filesgatsby-plugin-favicon-mperkhgatsby-source-published-google-sheetsgatsby-source-airtable-linkedgatsby-source-soundcloudgatsby-source-twitchgatsby-source-wordpress-bcgdvgatsby-transformer-nimblgatsby-transformer-whoaIf someone is feeling ambitious, development of the script discussed in #5211 could be continued in that issue for the future when more plugins leave off these keywords, but it'd be helpful to simply make a PR to existing repositories from the list above including the keywords and get these plugins included in the library.
Once a plugin has had keywords merged into it's repo, feel free to edit this issue to check it off the list 🙂
The text was updated successfully, but these errors were encountered: