Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gatsby-plugin-create-client-paths: Sets matchPath incorrectly for client side path entry #15011

Closed
sidharthachatterjee opened this issue Jun 21, 2019 · 0 comments · Fixed by #15014
Closed

gatsby-plugin-create-client-paths: Sets matchPath incorrectly for client side path entry #15011

sidharthachatterjee opened this issue Jun 21, 2019 · 0 comments · Fixed by #15014
Labels
status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. type: bug An issue or pull request relating to a bug in Gatsby

Comments

@sidharthachatterjee
Copy link
Contributor

sidharthachatterjee commented Jun 21, 2019 •
edited
Loading

When setting prefixes in the config for gatsby-plugin-create-client-paths, it seems that a client side path other than /* still gets its matchPath set to /* incorrectly.

This means that if a project has two different client side path entry points, say /* and /app/*, even for the second case, pages will reach the entry point for /*

Reproduction is at https://github.com/sidharthachatterjee/gatsby-15011-reproduction

Expected

http://localhost:8000/amhjajk should render Not Found in Index

Actual

http://localhost:8000/amhjajk renders Not Found in App
@sidharthachatterjee sidharthachatterjee added the type: bug An issue or pull request relating to a bug in Gatsby label Jun 21, 2019
@sidharthachatterjee sidharthachatterjee changed the title [bug] gatsby-plugin-create-client-paths: Sets matchPath incorrectly for client side path entry gatsby-plugin-create-client-paths: Sets matchPath incorrectly for client side path entry Jun 21, 2019
@sidharthachatterjee sidharthachatterjee added the status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. label Jun 21, 2019
@sidharthachatterjee sidharthachatterjee mentioned this issue Jun 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(gatsby-plugin-create-client-paths): set matchPath correctly gatsbyjs/gatsby
1 participant
@sidharthachatterjee