fix(gatsby-plugin-create-client-paths): set matchPath correctly #15014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidharthachatterjee
added
the
bot: merge on green
wardpeet
approved these changes
Jun 21, 2019
| @@ -18,7 +18,7 @@ exports.onCreatePage = ({ page, store, actions }, { prefixes }) => { | |||
| return resolve() | |||
| } | |||
|
|
|||
| prefixes.some(prefix => { | |||
| prefixes.forEach(prefix => { | |||
There was a problem hiding this comment.
github commmenting is dumb 💤
can you also remove the return true & return false from this function as forEach doesn't care.
I'm also thinking if we should drop the promise. What use has it?
There was a problem hiding this comment.
Promise shouldn't be necessary since createPage is an action creator and therefore not async
johno
pushed a commit
to johno/gatsby
that referenced
this pull request
Jul 17, 2019
…byjs#15014) * Add (failing) tests * Don't short circuit early * Fix README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array.some short circuits early whereas we need to run through all to get the best match
Fixes #15011