Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Breadcrumb shouldn't be dependent on trailing slash #20767

Closed
marcysutton opened this issue Jan 22, 2020 · 4 comments · Fixed by #24965
Closed

[docs] Breadcrumb shouldn't be dependent on trailing slash #20767

marcysutton opened this issue Jan 22, 2020 · 4 comments · Fixed by #24965
Labels
help wanted Issue with a clear description that the community can help with.

Comments

@marcysutton
Copy link
Contributor

marcysutton commented Jan 22, 2020

When writing an issue for new docs recipes, I noticed the breadcrumb fails to work if there is a trailing slash. Oddly, if you remove the trailing slash, the breadcrumb shows the full page hierarchy.

Here are some screenshots showing the difference:

With trailing slash (broken)

Gatsby recipe page with broken breadcrumb

Without trailing slash (working)

Gatsby recipe page with working breadcrumb

It would be good to fix this so the breadcrumb works either way, since the pages render either way. This one is up for grabs if anyone is interested in contributing a useful PR; it would be good to fix in the long term in case a URL with a trailing slash gets bookmarked or shared.

@marcysutton marcysutton added help wanted Issue with a clear description that the community can help with. 🎯Ecosystem labels Jan 22, 2020
@gabeszrozsa
Copy link

I'd like to grab it, interested in contributing

@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Feb 17, 2020
@github-actions
Copy link

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.
Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community! 💪💜

@marcysutton marcysutton added not stale and removed stale? Issue that may be closed soon due to the original author not responding any more. labels Mar 10, 2020
@marcysutton marcysutton reopened this Mar 10, 2020
@marcysutton
Copy link
Contributor Author

Hi @gabeszrozsa, this issue is still open! We would welcome your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issue with a clear description that the community can help with.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants