Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): breadcrumb issue with RFC process section in contributing page #24090

Merged
merged 1 commit into from
May 14, 2020
Merged

fix(docs): breadcrumb issue with RFC process section in contributing page #24090

merged 1 commit into from
May 14, 2020

Conversation

iamdarshshah
Copy link
Contributor

@iamdarshshah iamdarshshah commented May 14, 2020 •
edited
Loading

Description

Changes: added trailing slash to helps the user identify the hierarchy of page.

Fix: Breadcrumb issue with RFC process section resolved in /contributing/index.md

Related Issues
#20767

@iamdarshshah iamdarshshah requested a review from a team as a code owner May 14, 2020 14:18
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 14, 2020
@iamdarshshah iamdarshshah changed the title fix(docs): breadcrumb issue with RFC process section in docs/contributing fix(docs): breadcrumb issue with RFC process section in contributing page May 14, 2020
@iamdarshshah iamdarshshah added type: documentation An issue or pull request for improving or updating Gatsby's documentation status: needs docs review Pull request related to documentation waiting for review and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 14, 2020
AishaBlake
AishaBlake approved these changes May 14, 2020
View reviewed changes
Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks once again!

@AishaBlake AishaBlake merged commit 8c44389 into gatsbyjs:master May 14, 2020
@iamdarshshah iamdarshshah deleted the fix/docs-contributing branch May 14, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AishaBlake AishaBlake AishaBlake approved these changes

Assignees
No one assigned
Labels
status: needs docs review Pull request related to documentation waiting for review type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamdarshshah @AishaBlake