--prefix-paths flag is always enabled

[m-allanson]

Setting a pathPrefix in gatsby-config.js will cause gatsby build to use that path prefix in all production builds - i.e.gatsby build and gatsby build --prefix-paths produce the same output.

This means that sites built with gatsby build will have broken navigation and trigger errors in the browser console.

It looks like this is caused by an unexpected value in the equality check in loader.js. __PREFIX_PATHS__ is a ReferenceError instead of undefined. This causes the pathPrefix to be used, resulting in Gatsby being unable to match window paths with its own list of paths.

I'm a bit hazy on the precise differences between a ReferenceError and undefined, but hopefully this is enough info for someone to track down the problem.

I've created an example repo (based on gatsby's default starter) that demonstrates the problem at https://github.com/m-allanson/gatsby-path-prefix-test

[hemantsan]

I am also getting this same issue. Anyone has a fix ?

[m-allanson]

@vieckys this should have been fixed a while ago. Are you using a recent version of Gatsby?

[hemantsan]

@m-allanson hmm it may be 2 - 3 months old.

[m-allanson]

Ok I’d try updating to a newer version

…

On 28 Mar 2018, 07:02 +0200, Hemant Sankhla ***@***.***>, wrote: hmm it may be 2 - 3 months old. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[JimLynchCodes]

I'm getting the opposite- neither gatsby build nor gatesby build --prefix-paths add the prefix to my url: greglobinski/gatsby-starter-hero-blog#54