fix(gatsby-plugin-image): Correctly handle formats in StaticImage #28618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
ascorbic
removed
the
status: triage needed
ascorbic
changed the title
Lazy-load tests currently fail if there's a webp image. This will need a proper fix later, but not in this PR. This reverts commit 7f1cd2a.
ascorbic
added
the
topic: media
mfrachet
approved these changes
Dec 15, 2020
LekoArts
pushed a commit
that referenced
this pull request
Dec 15, 2020
…8618) * Include formats prop * Default to auto, webp * fix(gatsby-plugin-sharp): Include default transform options for webp * Update snapshots * Is this why it fails? * Allow time for other image * Use jpg-only for lazy-load tests. Lazy-load tests currently fail if there's a webp image. This will need a proper fix later, but not in this PR. This reverts commit 7f1cd2a. (cherry picked from commit 912f30c)
LekoArts
added a commit
that referenced
this pull request
Dec 15, 2020
…8618) (#28630) * Include formats prop * Default to auto, webp * fix(gatsby-plugin-sharp): Include default transform options for webp * Update snapshots * Is this why it fails? * Allow time for other image * Use jpg-only for lazy-load tests. Lazy-load tests currently fail if there's a webp image. This will need a proper fix later, but not in this PR. This reverts commit 7f1cd2a. (cherry picked from commit 912f30c) Co-authored-by: Matt Kane <matt@gatsbyjs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The StaticImage component wasn't correctly extracting the
formatsprop