Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-image): Correctly handle formats in StaticImage #28516

Closed
wants to merge 3 commits into from
Closed

fix(gatsby-plugin-image): Correctly handle formats in StaticImage #28516

wants to merge 3 commits into from

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Dec 7, 2020

The StaticImage component wasn't correctly extracting the formats prop

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 7, 2020
@ascorbic ascorbic added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 7, 2020
@laurieontech
Copy link
Contributor

The code looks fine, but we should fix the e2e tests.

@ascorbic ascorbic mentioned this pull request Dec 15, 2020
Merged
@ascorbic
Copy link
Contributor Author

ascorbic commented Dec 15, 2020 •
edited
Loading

Closing in favour of #28618

@ascorbic ascorbic closed this Dec 15, 2020
@LekoArts LekoArts deleted the fix/static-image-formats branch April 23, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurieontech laurieontech laurieontech approved these changes

Assignees
No one assigned
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ascorbic @laurieontech