Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gatsby-plugin-netlify: mergeLinkHeaders: true resulting in huge _headers files that fail builds #28693

Closed
kaganjd opened this issue Dec 18, 2020 · 8 comments · Fixed by #29168
Closed

gatsby-plugin-netlify: mergeLinkHeaders: true resulting in huge _headers files that fail builds #28693

kaganjd opened this issue Dec 18, 2020 · 8 comments · Fixed by #29168
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation

Comments

@kaganjd
Copy link

kaganjd commented Dec 18, 2020

Summary

Netlify support here 👋🏻 We've seen several customers in our helpdesk with large builds that time out and fail for the same reason: a very big (> 15MB) _headers file that was generated by gatsby-plugin-netlify. When they toggle mergeLinkHeaders to false, this resolves their issue. It seems like there be a documentation gap here about what that option does.

Here are the current docs on the plugin: https://www.gatsbyjs.com/plugins/gatsby-plugin-netlify/

Motivation

Less frustration for Gatsby developers who are deploying large sites on Netlify

Let me know if we can provide any other info to help!
@kaganjd kaganjd added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Dec 18, 2020
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 18, 2020
@vladar vladar added topic: netlify and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 18, 2020
@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Jan 8, 2021
@wardpeet
Copy link
Contributor

@kaganjd is it possible to share a headers file through email? ward@gatsbyjs.com

@github-actions github-actions bot removed the stale? Issue that may be closed soon due to the original author not responding any more. label Jan 11, 2021
@kaganjd
Copy link
Author

kaganjd commented Jan 16, 2021

We can't due to data privacy stuff, but we've let the most recent customer who hit this know they can share their _headers file with you directly if they want.

isabelleingato added a commit to isabelleingato/gatsby that referenced this issue Jan 24, 2021
@isabelleingato
docs(gatsby-plugin-netlify): Update readme
429b2db 
Add context for mergeLinkHeaders option

Fixes gatsbyjs#28693
@isabelleingato isabelleingato mentioned this issue Jan 24, 2021
Merged
@isabelleingato
Copy link
Contributor

Hey @wardpeet and @kaganjd,

I'm new here, and I'd like to grab this one. Would that be okay?

@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Feb 14, 2021
@kaganjd
Copy link
Author

kaganjd commented Feb 14, 2021

Hey @isabelleingato- thanks so much for opening a PR for this! I don't know what the process is on the Gatsby side but it looks like your PR didn't pass CI tests so it never got automatically merged. Would you be up for digging into whatever's wrong?

@github-actions github-actions bot removed the stale? Issue that may be closed soon due to the original author not responding any more. label Feb 14, 2021
gatsbybot pushed a commit that referenced this issue Feb 14, 2021
@isabelleingato @meganesu
docs(gatsby-plugin-netlify): Update readme (#29168)
f82678f 
* docs(gatsby-plugin-netlify): Update readme

Add context for mergeLinkHeaders option

Fixes #28693

* Typo

Remove accidental slash

* fix: lint

Co-authored-by: Megan Sullivan <megan@gatsbyjs.com>
@isabelleingato
Copy link
Contributor

Hey @isabelleingato- thanks so much for opening a PR for this! I don't know what the process is on the Gatsby side but it looks like your PR didn't pass CI tests so it never got automatically merged. Would you be up for digging into whatever's wrong?

@kaganjd Thanks for the heads up, I just needed to merge master! The update to the README is now merged.

@kaganjd
Copy link
Author

kaganjd commented Feb 14, 2021

Amazing! Many thanks from the Netlify Support team- this will be a big help for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(gatsby-plugin-netlify): Update readme isabelleingato/gatsby
4 participants
@vladar @wardpeet @isabelleingato @kaganjd