-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gatsby-transformer-yaml] README.md differs from reality #3081
Comments
@DamnedScholar does your yaml file have a field named "value"? @Charon77 you're right! Would you like to PR a fix? |
@KyleAMathews Ah-ha! I see now. That was my fault, of course, but I was having trouble finding |
@KyleAMathews Sure thing!
among other things. |
PR in #3154 |
* Adds modle.exports example * Moves module.exports example to 'How to use' * Describes Parsing algorithm * Renames 'value' to 'character' to avoid confusion * Renames more 'value' to 'character'; Changes 'allLetters' to 'allLettersYaml' * Supported extensions, How to query, Note that you need files * Notes that .yaml and .yml are used in the same way.
This issue refers to gatsby-transformer-yaml README.md.
I'm using gatsby-transformer-yaml 1.5.12.
Summary:
I believe README.md is not accurate or does not represent the current version thus needs to be updated.
Highlights:
type
is insideinternal
and does not reside alongsidevalue
Issue 1. -Yaml ending.
The readme says:
...
Then the following three nodes would be created.
However, after running gatsby with this directory structure:
I only have this node:
as opposed to
as stated in the README. I don't knkow where the
Yaml
ending comes from.Issue 2. -
type
does not existThe Readme says:
However, running allLettersYaml through GraphQL:
Doesn't work, because there is no
type
field. Looking up the source code reveals that this happens becausetype
is insideinternal
.But, this works:
Conclusion
I believe the Readme needs updating, but it could also be that I'm wrong, maybe I use the wrong version or interpreted the Readme wrongly. If I'm right and indeed the Readme needs updating, I'd like to give PR.
Thank you.
The text was updated successfully, but these errors were encountered: