Update building-apps-with-gatsby.md #10255
Conversation
Add docs about avoiding request waterfalls with client routes by overriding component renderer `key` prop (gatsbyjs#10227 (comment)) Closes gatsbyjs#10227
| @@ -53,3 +53,18 @@ exports.onCreatePage = async ({ page, actions }) => { | |||
| > [gatsby-plugin-create-client-paths](/packages/gatsby-plugin-create-client-paths/). | |||
|
|
|||
| Check out the ["simple auth" example site](https://github.com/gatsbyjs/gatsby/blob/master/examples/simple-auth/README.md) for a demo implementing user authentication and restricted client-only routes. | |||
|
|
|||
| ### Known Issues | |||
There was a problem hiding this comment.
Probably needs a better heading.
There was a problem hiding this comment.
LGTM. Just left one comment (and I don't have a better name for the heading 😆 ).
Linting CI is currently failing, you can run prettier this way:
npx prettier --write docs/docs/building-apps-with-gatsby.mdor
npm install -g prettierand then
prettier --write docs/docs/building-apps-with-gatsby.md
|
sorry i'm on my phone. can you run prettier? |
Co-Authored-By: jaredpalmer <jaredloganpalmer@gmail.com>
|
After chat with @KyleAMathews we decided to fix/change this for client-only-paths ( #10261 ) + add some tests to catch any regressions in future. We will need to update docs on this, but message from this PR will need to be inverted - but that's on us. Thanks for jumping on adding this "gotcha" to docs while we were still debating how to approach the problem. |
|
Honestly, was very confused as to why this was not the default at first. Def agree that it should be as gatsby is billed as an "app" toolchain too. Makes wayyyy more sense now. |
|
Yeah - good call @LekoArts. @jaredpalmer thanks for this PR, but since we fixed the underlying issue, that's probably preferable over documenting something that isn't necessarily needed. If I'm off-base, please feel free to re-open and we can chat further! Thanks for using Gatsby 💜 |
Add docs about avoiding request waterfalls with client routes by overriding component renderer
keyprop (#10227 (comment))Closes #10227