chore: add starters to monorepo #10310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSchau
commented
Dec 5, 2018
.circleci/config.yml
Outdated
| @@ -133,6 +133,20 @@ jobs: | |||
| - <<: *attach_to_bootstrap | |||
| - run: yarn test:integration | |||
|
|
|||
| starters_publish: | |||
There was a problem hiding this comment.
I'll add back the other jobs, but this is helpful to validate this approach and get feedback more quickly.
See CircleCI for an example run.
|
Oh cool! Yeah run Cypress tests and then remove them before syncing with the read-only repos. |
DSchau
added a commit
to DSchau/gatsby
that referenced
this pull request
Dec 12, 2018
This PR introduces a create-repos script which will likely be used either manually, or as part of some CI process relating to gatsbyjs#10310, e.g. on master push and examples/* change, run this script. I've made some assumptions here, specifically: - examples are starters, and we can create the repo `gatsby-starter-*` for every example - using-* should be replaced, e.g. `using-styled-components` should become `gatsby-starter-styled-components` - that it makes sense to install dependencies for scripts and add them to the yarn workspace I think these all make sense, but sanity check appreciated.
|
More work to do here: The clone and copy files approach won't work; how do we handle deleted files? Follow along at DSchau#5, trying a new approach. I think I'll have to merge origin/master and that should do the trick. |
|
One last thing to do, then we should be able to merge.
|
|
Bot to close all new pull requests to starter repos is ready at gatsbyjs/peril-gatsbyjs#64 |
pieh
approved these changes
Dec 20, 2018
This was referenced Dec 21, 2018
Closed
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
This PR adds in starters to the monorepo. Longer term, I believe we'll merge starters/examples since they're very much linked. Future implementation improvements: - Run a `build` script to validate that the starter(s) can be built - I planned to use `lerna run --scope gatsby-starter-*` for this, but if there's another approach, happy to try that - Implement yarn workspaces/lerna so we can get automatic versioning in the starters (I have this built out at https://github.com/dschau/starters) - Author `e2e` tests vs. the starters so that we can ensure we're not breaking anything - These would follow a similar approach to the current e2e tests Blocked by gatsbyjs/gatsby-starter-blog#139 gatsbyjs/gatsby-starter-default#120 gatsbyjs/gatsby-starter-hello-world#32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in starters to the monorepo. Longer term, I believe we'll merge starters/examples since they're very much linked.
Future implementation improvements:
buildscript to validate that the starter(s) can be builtlerna run --scope gatsby-starter-*for this, but if there's another approach, happy to try thate2etests vs. the starters so that we can ensure we're not breaking anythingBlocked by
gatsbyjs/gatsby-starter-blog#139 gatsbyjs/gatsby-starter-default#120 gatsbyjs/gatsby-starter-hello-world#32