-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Starter Library URL and update copy #10368
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LekoArts
approved these changes
Dec 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
shannonbux
approved these changes
Dec 11, 2018
Holy buckets, @rgoldfinger — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Thank you @rgoldfinger! |
m-allanson
added a commit
to markza/gatsby
that referenced
this pull request
Dec 11, 2018
* master: (1432 commits) chore(release): Publish Fix Starter Library URL and update copy (gatsbyjs#10368) feat(gatsby-source-filesystem): keep original name of remote files (gatsbyjs#9777) docs(gatsby-source-contentful): Rewrite of gatsby-source-contentful query section (gatsbyjs#7533) Update "Deploying with Now" Guide (gatsbyjs#10390) Add Matomo to list of analytics plugins (gatsbyjs#10372) Add satispay.com to showcase (gatsbyjs#10380) Adds @goblindegook/gatsby-starter-typescript (gatsbyjs#10377) Fix typo in gatsby-remark-code-repls sample `gatsby-config.json` in README (gatsbyjs#10361) fix(gatsby): fix false type conflict warning on plugin fields (gatsbyjs#10355) fix(docs): Just a small typo fix in the docs (gatsbyjs#10359) feat(gatsby-image): add onStartLoad prop (gatsbyjs#6702) fix(docs): add Ecosystem to docs sidebar, consistency with tutorial sidebar (gatsbyjs#10350) fix(www): Starters.yaml housekeeping (gatsbyjs#10354) docs: add ttag starter (gatsbyjs#10352) docs: document branching (gatsbyjs#9983) plugin checker initial commit (gatsbyjs#7062) docs: new starter features is required (gatsbyjs#10353) docs: migrated line highlighting to highlight-line, highlight-start, highlight-end (gatsbyjs#10202) Add Birra Napoli to site showcase (gatsbyjs#10344) ...
m-allanson
added a commit
to alexkirsz/gatsby
that referenced
this pull request
Dec 12, 2018
* master: (1425 commits) showcase: Add TMDb Gatsby site (gatsbyjs#10411) chore(www): bump offline plugin version (gatsbyjs#10409) chore(release): Publish Fix Starter Library URL and update copy (gatsbyjs#10368) feat(gatsby-source-filesystem): keep original name of remote files (gatsbyjs#9777) docs(gatsby-source-contentful): Rewrite of gatsby-source-contentful query section (gatsbyjs#7533) Update "Deploying with Now" Guide (gatsbyjs#10390) Add Matomo to list of analytics plugins (gatsbyjs#10372) Add satispay.com to showcase (gatsbyjs#10380) Adds @goblindegook/gatsby-starter-typescript (gatsbyjs#10377) Fix typo in gatsby-remark-code-repls sample `gatsby-config.json` in README (gatsbyjs#10361) fix(gatsby): fix false type conflict warning on plugin fields (gatsbyjs#10355) fix(docs): Just a small typo fix in the docs (gatsbyjs#10359) feat(gatsby-image): add onStartLoad prop (gatsbyjs#6702) fix(docs): add Ecosystem to docs sidebar, consistency with tutorial sidebar (gatsbyjs#10350) fix(www): Starters.yaml housekeeping (gatsbyjs#10354) docs: add ttag starter (gatsbyjs#10352) docs: document branching (gatsbyjs#9983) plugin checker initial commit (gatsbyjs#7062) docs: new starter features is required (gatsbyjs#10353) ...
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
Previously the "starter list" linked to a page that wasn't found. This fixes it and updates the copy to reflect the current name. <!-- Q. Which branch should I use for my pull request? A. Your best bet is to go for `master`. If you are unsure, ask in the PR, and a Gatsby mantainer will be happy to help :) Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2. Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/ -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the "starter list" linked to a page that wasn't found. This fixes it and updates the copy to reflect the current name.