Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct function in example code #10433

Closed
wants to merge 1 commit into from
Closed

Use correct function in example code #10433

wants to merge 1 commit into from

Conversation

nikoladev
Copy link
Contributor

window.prompt() doesn't return a boolean value, window.confirm() does :)

See https://developer.mozilla.org/en-US/docs/Web/API/Window/confirm

@nikoladev nikoladev requested a review from a team December 12, 2018 11:05
@nikoladev nikoladev changed the title fix bug in example code Use correct function in example code Dec 12, 2018
@LekoArts
Copy link
Contributor

Hi 👋
Thanks for the PR! However David already opened up a PR for that:
#10431

Therefore I'm going to close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants