Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the error message when a non-page component exports a query #10765

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

KyleAMathews
Copy link
Contributor

@KyleAMathews KyleAMathews commented Jan 2, 2019

Generally it's a problem in their gatsby-node.js so we should point
people there.

Generally it's a problem in their gatsby-node.js so we should point
people there.
@KyleAMathews KyleAMathews requested a review from a team as a code owner January 2, 2019 01:11
@KyleAMathews KyleAMathews changed the title <!-- Have any questions? Check out the contributing docs at https://gatsby.app/contribute, or ask in this Pull Request and a Gatsby maintainer will be happy to help :) --> Improve the error message when a non-page component exports a query Jan 2, 2019
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@DSchau DSchau merged commit f780bdd into master Jan 2, 2019
@DSchau DSchau deleted the better-message branch January 2, 2019 12:47
@DSchau
Copy link
Contributor

DSchau commented Jan 2, 2019

Successfully published:
 - gatsby@2.0.82

DSchau pushed a commit that referenced this pull request Jan 2, 2019
Follow-up to #10765


<!--
  Have any questions? Check out the contributing docs at https://gatsby.app/contribute, or
  ask in this Pull Request and a Gatsby maintainer will be happy to help :)
-->


<!-- Write a brief description of the changes introduced by this PR -->


<!--
  Link to the issue that is fixed by this PR (if there is one)
  e.g. Fixes #1234, Addresses #1234, Related to #1234, etc.
-->
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
…atsbyjs#10765)

 Generally it's a problem in their gatsby-node.js so we should point
    people there.
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
Follow-up to gatsbyjs#10765


<!--
  Have any questions? Check out the contributing docs at https://gatsby.app/contribute, or
  ask in this Pull Request and a Gatsby maintainer will be happy to help :)
-->


<!-- Write a brief description of the changes introduced by this PR -->


<!--
  Link to the issue that is fixed by this PR (if there is one)
  e.g. Fixes gatsbyjs#1234, Addresses gatsbyjs#1234, Related to gatsbyjs#1234, etc.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants