fix(gatsby): test plugin name to handle symlinks, rather than path #10835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simple PR augments the behavior to test the plugin's name, rather than the plugin's resolved path, in the case that it could be symlinked/linked. This seems to match the behavior we're expecting, and _again_ will be cleaned up when gatsbyjs#10787 lands.
DSchau
commented
Jan 4, 2019
| @@ -66,7 +66,7 @@ const overlayErrorID = `graphql-compiler` | |||
|
|
|||
| const resolveThemes = (plugins = []) => | |||
| plugins.reduce((merged, plugin) => { | |||
| if (plugin.resolve.includes(`gatsby-theme-`)) { | |||
| if (plugin.name.includes(`gatsby-theme-`)) { | |||
There was a problem hiding this comment.
plugin.resolve is the symlinked path when running yarn link or npm link. This change will work with symlinked modules and "regular" (e.g. modules in node_modules) alike.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This simple PR augments the behavior to test the plugin's name, rather
than the plugin's resolved path, in the case that it could be
symlinked/linked. This seems to match the behavior we're expecting, and
again will be cleaned up when #10787 lands.
Related Issues
Related to #10787, #10786