-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-plugin-checker): add more filters to filter out bad packages #11093
Conversation
…lack a repository, have bad repo links, incorrect name formats, or lack READMEs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this one! I added a few comments.
Hi @reese 👋 |
Yes, I'll get back to these once I get a chance! Sorry for the delay, hopefully will get to it in the next few days. |
…t repo has README.
@reese I'm so sorry to let you do all this work but I think it was all for nothing. Initially I thought we were using this on www but we're not using this package anywhere. We use gatsby-source-npm-package-search. Maybe you're using it and have a use case you want to share? |
@wardpeet This was a script that was requested in Issue #5211. The goal initially was to have this script available for manual usage. The idea is that since not all repos mention the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long! This is amazing! Thanks so much for updating this script!
Holy buckets, @reese — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Description
Updating the gatsby-plugin-checker. It now filters out packages that lack a repository, have bad repo links, incorrect name formats, or lack READMEs. It also created a README in the folder to explain functionality and future features (such as automated notifications).
Related Issues
This PR stems from issue #5211 . Note that the script still doesn't automatically create issues yet. As mentioned after PR #7062, this requires a Github API key, so the best solution would likely be to put the key in an ENV variable and then run it locally. I'll leave this for a later PR.