fix: use require instead if the ESM import statement

[DanielRuf]

Description

This fixes an issue with the build script.

In the dev mode it seems we have the babel transform plugin for the engine and dynamic require / import.

But the build does not and we have to use require. In fact the code in this file uses exports but not the require. I guess this was overseen.

We should use the CJS way to use them (require) instead of the ESM one (import).

https://github.com/gatsbyjs/gatsby/blame/master/packages/gatsby/src/internal-plugins/query-runner/pages-writer.js#L97

https://github.com/gatsbyjs/gatsby/blame/master/packages/gatsby/src/internal-plugins/query-runner/pages-writer.js#L104

Related Issues

#11198

[DanielRuf]

Hm, does my change break the tests? It seems so.

[pieh]

It seems like You are changing dynamic import into static one here. What about doing this other way and making this entirely ESM:
exports.data => export const data?
It's also suprising that it break things for some people, but not for others :/

[pieh]

Do you have example project that is failing currently that I could investigate?

[DanielRuf]

@pieh see #11198 (comment) for a repository for testing the problem. All previous gatsby releases have this issue so it might be because of another dependency.

[DanielRuf]

It seems a new install (using Yarn) does not have this issue. I'll do a diff between the working and not working setup.

[DanielRuf]

exports.data => export const data?

This does not change anything, the needed runtime transforms are still not applied.

I think it is different between Yarn and npm.

[pieh]

Yeah, I cloned the reproduction and had same problem when installing with npm - but after wiping lock file and reinstalling node_modules with npm problem went away, so to me it seems like some dependency issues

[DanielRuf]

Seems so. But so far we do not know the exact cause. I'm closing the PR.

[DanielRuf]

It seems it still happens with npm, but not Yarn.