Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(webpack.config.js) Fix test for one CSS chunk to cover more flavors of CSS #11927

Merged
merged 2 commits into from
Feb 20, 2019

Conversation

KyleAMathews
Copy link
Contributor

No description provided.

@KyleAMathews KyleAMathews requested a review from a team as a code owner February 20, 2019 12:12
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't super scalable we might want to introduce some function plugins can call or perhaps look into our wordpress rules to match rules with css-loader.

Good enough to have as a quick fix though!

packages/gatsby/src/utils/webpack.config.js Outdated Show resolved Hide resolved
@KyleAMathews
Copy link
Contributor Author

Lots of styl fans haha :-P

@pieh pieh merged commit c2c66b9 into master Feb 20, 2019
@pieh pieh deleted the css-splits-follup branch February 20, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants