fix(gatsby-source-filesystem): Do not re-download cached files from createRemoteFileNode #12054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidharthachatterjee
approved these changes
Feb 25, 2019
| @@ -145,7 +145,7 @@ async function pushToQueue(task, cb) { | |||
| const requestRemoteNode = (url, headers, tmpFilename) => | |||
| new Promise((resolve, reject) => { | |||
| const responseStream = got.stream(url, { | |||
| ...headers, | |||
| headers, | |||
| // Save the response headers for future requests. | ||
| await cache.set(cacheId(url), response.headers) | ||
|
|
||
| if (response.statusCode == 200) { |
There was a problem hiding this comment.
Do we need to handle any other successful response status codes? Like 201 etc
I noticed that we also check for only 200 later in the file when moving temp data over so I'd guess we should be okay.
|
Merging this in because I think it's good for now with the check for 200. We'll revisit this in case we find that it's not. Still a great fix of course! Thank you @skinandbones 👍 |
|
Holy buckets, @skinandbones — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
mwfrost
pushed a commit
to mwfrost/gatsby
that referenced
this pull request
Apr 20, 2023
…reateRemoteFileNode (gatsbyjs#12054) * Correct headers option for got() in createRemoteFileNode. * Only encache response headers for success responses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes multiple issues in
createRemoteFileNodethat is causing the cache mechanism to not work correctly:got()correctly.Related Issues
Fixes #12053
There are some issues reported in
gatsby-source-wordpressabout large downloads on restarts/builds that sound like they could be related.