Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a community events page #12929

Merged
merged 8 commits into from
Apr 26, 2019
Merged

Conversation

jlengstorf
Copy link
Contributor

@jlengstorf jlengstorf commented Mar 29, 2019

This is a WIP for adding a community events page to the site.

TODO:

  • load event data from Airtable
  • make sure development doesn’t fail if no Airtable API key is found
  • create a React Hook to load community event data
  • create components to display event data on the page
  • style the events page
  • write copy for the events page
  • add a link to submit new events

cc @lindaleebumblebee

Screenshot:

Community Events   GatsbyJS

This is a WIP for adding a community events page to the site.

TODO:
- [x] load event data from Airtable
- [x] make sure development doesn’t fail if no Airtable API key is found
- [x] create a React Hook to load community event data
- [ ] create components to display event data on the page
- [ ] style the events page
- [ ] write copy for the events page
- [x] add a link to submit new events
@lindaleebumblebee
Copy link
Contributor

I wrote the landing page copy to invite community members to submit their event (which we'll want to link to from the events page). For copy for the events page, do you have any space requirements (number of words) you want me to stay within?
Landing page to submit event: https://docs.google.com/document/d/1MHnuoRvshS4IE925UhBsZQE_uUfBHY5YtxzDApyZkAQ/edit

www/gatsby-node.js Show resolved Hide resolved
www/gatsby-node.js Show resolved Hide resolved
www/gatsby-node.js Show resolved Hide resolved
www/gatsby-node.js Outdated Show resolved Hide resolved
www/src/pages/contributing/events.js Outdated Show resolved Hide resolved
@jlengstorf
Copy link
Contributor Author

@lindaleebumblebee no limits on text, but probably it would be wise to keep it relatively short so the events are visible on initial load for both desktop and mobile. Ultimately, it's your call, so whatever you think is right is what we'll do. 😄

@KyleAMathews
Copy link
Contributor

@jlengstorf ping — is this easy to finish out? Looks really valuable!

@jlengstorf
Copy link
Contributor Author

@KyleAMathews this is code complete pending a one-line change, but the table is full of test events. @lindaleebumblebee do you have time to clean up that table?

I'll make the last change and take this live as soon as the data is ready.

@jlengstorf jlengstorf marked this pull request as ready for review April 25, 2019 22:32
@jlengstorf jlengstorf requested a review from a team as a code owner April 25, 2019 22:32
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno about the tests but the screenshot looks great!

<h1 id="contributing-gatsby" css={{ marginTop: 0 }}>
Gatsby Community Events
</h1>
<p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we link to the new community events page? https://www.gatsbyjs.org/contributing/organize-a-gatsby-event/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lindaleebumblebee what do you think here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what Linda votes, but I vote yes! "Or, organize your own event!"

@jlengstorf jlengstorf merged commit 1443d4c into master Apr 26, 2019
@jlengstorf jlengstorf deleted the feat/community-events-page branch April 26, 2019 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants