chore(www): Align more design tokens with system-ui spec (refactor breakpoints to contain raw values, add presets.mediaQueries derived from it for convenience)
#13388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eakpoints to contain raw values, add `presets.mediaQueries` derived from it for convenience)
…diaQueries # Conflicts: # www/src/views/creators/creators-header.js
KyleAMathews
deleted the
topics/www-design-tokens-mv-breakpoints-mediaQueries
branch
|
Ah sweet, thank you! |
fk
added a commit
that referenced
this pull request
Apr 25, 2019
Merged
marcysutton
pushed a commit
that referenced
this pull request
May 14, 2019
* initial feedback widget integration * update widget with greg's fabulous styles + state * add emotion plugin to jest-preprocess * improve focus management in screens * remove widget from features page * Use design tokens (1/2) There’s more to do, but this is a start… - remove `font-family: sans-serif` along the way - remove components/feedback-widget/presets in favor of utils/presets.breakpoints * fix: height of widget * Use design tokens (2/2) - chose to reduce the border around the „emoji toggle buttons“ from 3 to 1px - add horizontal margin for screens below desktop/lg * Fix max-width, overlapping navigation button for small screens * Swap `breakpoints` -> `mediaQueries Ref. #13388 * fix(www): improve feedback-widget toggle button and hover state (#13923) * fix focus style in Safari * fix React submit issue for keyboard entry * remove unused code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #13107 and #13107 (comment), this refactors
www/src/utils/tokens/breakpoints.jsto contain the "raw" breakpoint values, and moves the formerbreakpointsconvenience strings (ready to be used as CSS media queries) towww.src/utils/tokens/media-queries.jsandpresets.mediaQueries.Ref. https://system-ui.com/theme/
/cc @jxnblk @johno