Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin authoring blogpost first draft #13576

Merged
merged 3 commits into from
Apr 27, 2019
Merged

Conversation

shannonbux
Copy link
Contributor

@shannonbux shannonbux commented Apr 23, 2019

@oorestisime, @TylerBarnes, @rexxars, @ChristopherBiscardi, @pieh, @m-allanson is it alright with you if I mention you to thank you in this post? I will probably link to your twitter or github accounts too, if you're cool with that. There are also a couple quotes.

@shannonbux shannonbux requested a review from a team April 23, 2019 18:21
@oorestisime
Copy link
Contributor

yeap and thanks :)
(small note from the draft, I am not the author of gatsby-source-pilon, i have just worked on it as part of a contract)

@rexxars
Copy link
Contributor

rexxars commented Apr 23, 2019

Of course! And thanks 😊

@TylerBarnes
Copy link
Contributor

Totally cool with that :)

@ChristopherBiscardi
Copy link
Contributor

@shannonbux cool with me 👍

@m-allanson
Copy link
Contributor

@shannonbux all good with me too :)

shannonbux added 2 commits April 25, 2019 13:22
Doing this @ChristopherBiscardi since the Gatsby plugin library isn't rendering the images correctly.
@shannonbux shannonbux merged commit 0977101 into master Apr 27, 2019
@shannonbux shannonbux deleted the plugin-authoring-blogpost branch April 27, 2019 00:35
@missmatsuko
Copy link
Contributor

I noticed this folder is in the docs root which seems kind of out of place:
https://github.com/gatsbyjs/gatsby/tree/master/docs

Was this intentional (because it's a draft?) or should it be moved?

The page does seem to be public on the site already:
https://www.gatsbyjs.org/2019-04-25-plugin-authoring-study/

@KyleAMathews
Copy link
Contributor

@missmatsuko that was a mistake — I'll move it real quick

@KyleAMathews
Copy link
Contributor

Thanks for noticing!

@shannonbux
Copy link
Contributor Author

yes @missmatsuko thank you for noticing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants