[schema] Ensure default by: id for link() resolver #13591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,7 +93,7 @@ const paginate = (results = [], { skip = 0, limit }) => { | |||
| } | |||
| } | |||
|
|
|||
| const link = ({ by, from }) => async (source, args, context, info) => { | |||
| const link = ({ by = `id`, from }) => async (source, args, context, info) => { | |||
There was a problem hiding this comment.
I wonder if we can/need to generate a unique id (based on timestamp or something) to set as default?
There was a problem hiding this comment.
@sidharthachatterjee This is about the default node field for foreign-key relations. So that it is possible to say something like this in SDL:
type Post implements Node {
author: AuthorJson @addResolver(type: "link")
# instead of:
# author: AuthorJson @addResolver(type: "link", options: { by: "id" })
}The ID itself must already be unique on nodes. Hope that make sense?
There was a problem hiding this comment.
That makes sense! Thank you for the added context, @stefanprobst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #13028
Because
addResolverdirective is generic we don't have defaultValue for options. So better ensure we have defaultby: idarg for link resolver.