fix(gatsby): fixes react-hot-reloader for new react features #13610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardpeet
changed the title
pieh
approved these changes
Apr 25, 2019
|
Published in |
|
Did this break dev mode in IE11? Getting |
|
This may be related to a break in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes HMR for hooks & suspense features with react-🔥-dom. It uses the webpack loader to patch react-dom as react-dom is a peer dependency we can't force users to install
@hot-loader/react-domas mentioned in the README of react-hot-loader.After:
Before:
It also actually fixes HMR for components using hooks 😛 not just remove the message.
Related Issues
#11934