Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(starters): add gatsby-starter-sass #13677

Merged
merged 4 commits into from
Apr 29, 2019
Merged

chore(starters): add gatsby-starter-sass #13677

merged 4 commits into from
Apr 29, 2019

Conversation

colbyfayock
Copy link
Contributor

Description

Adds a new starter that scaffolds a super minimal Gatsby project with Sass stylesheets

@colbyfayock colbyfayock requested a review from a team April 27, 2019 21:47
@colbyfayock
Copy link
Contributor Author

colbyfayock commented Apr 27, 2019 •
edited
Loading

🤔i dont think this would have to do with my change, but i see another PR ahead of mine that isn't failing this specific test...

Edit: yarn run bootstrap with node 12.0.0 locally wont even run 🤷‍♀️

freiksenet
freiksenet suggested changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@freiksenet freiksenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your PR and for your work on starter! Could you please update the tags so that they match the categories on the website?

docs/starters.yml Outdated
repo: https://github.com/colbyfayock/gatsby-starter-sass
description: A Gatsby starter with Sass and no assumptions!
tags:
- Sass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no Styles tag (see https://www.gatsbyjs.org/starters/?v=2 and "categories"). Could you change those to Styling:Sass, Styling:SCSS and remove CSS and Styles tags?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styling:SCSS is pretty much the only one needed here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't occur to me those tags were the categories 🤦‍♂it's fixed now. I would have added Styling:Sass too, but that doesnt seem to exist in the current list

@colbyfayock
Copy link
Contributor Author

fixed the conflict in the UI and the linter didn't run, so it didnt pick up the EOL lint issue 😅

fixed ✅

KyleAMathews
KyleAMathews approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@KyleAMathews KyleAMathews merged commit 84becd3 into gatsbyjs:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts left review comments

@KyleAMathews KyleAMathews KyleAMathews approved these changes

@freiksenet freiksenet freiksenet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@colbyfayock @KyleAMathews @freiksenet @LekoArts