chore(gatsby): warn about service workers running in development #13716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 29, 2019 15:43
- Remove supportsServiceWorkers() since it was only used in one place - Instead of automatically removing SWs, warn about them
DSchau
changed the title
DSchau
added
the
status: awaiting reviewer response
|
I wonder if a console.warn is enough :p, maybe we should inject some kind of "console" in gatsby dev. I think it's okay to ship but might need some more iterations on this. Great job |
wardpeet
approved these changes
May 3, 2019
wardpeet
added
bot: merge on green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Warn about service workers detected on a site running in development, rather than removing them automatically.
Related Issues
#12834