Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(gatsby-plugin-netlify): remove comment that states to put it last #13749

Merged
merged 2 commits into from
May 1, 2019
Merged

docs(gatsby-plugin-netlify): remove comment that states to put it last #13749

merged 2 commits into from
May 1, 2019

Conversation

smakosh
Copy link
Contributor

@smakosh smakosh commented Apr 30, 2019 •
edited
Loading

Description

Removes a comment stating to put netlify plugin as last item on the array of plugins
Depends on: #13750

@smakosh smakosh added type: documentation An issue or pull request for improving or updating Gatsby's documentation status: assigned status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response labels Apr 30, 2019
@smakosh smakosh requested a review from KyleAMathews April 30, 2019 16:55
@smakosh smakosh self-assigned this Apr 30, 2019
@smakosh smakosh mentioned this pull request Apr 30, 2019
Closed
DSchau
DSchau suggested changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you bring the changes over from #13750 into this PR? I'm not really sure I see the need for two separate PRs.

@smakosh
Copy link
Contributor Author

smakosh commented Apr 30, 2019

Can't push any other commit to this branch as it's protected

@DSchau DSchau changed the title Remove comment that states to put it last docs(gatsby-plugin-netlify): remove comment that states to put it last May 1, 2019
@DSchau DSchau merged commit f223091 into master May 1, 2019
@DSchau
Copy link
Contributor

DSchau commented May 1, 2019

Thank you!

@paschalidi paschalidi mentioned this pull request May 1, 2019
Closed
@wardpeet wardpeet deleted the smakosh-patch-1 branch June 27, 2019 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSchau DSchau DSchau approved these changes

@KyleAMathews KyleAMathews Awaiting requested review from KyleAMathews

Assignees

@smakosh smakosh

Labels
status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smakosh @DSchau