Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add variable usage to Gatsby Node API docs #13864

Merged
merged 2 commits into from
May 7, 2019
Merged

docs: Add variable usage to Gatsby Node API docs #13864

merged 2 commits into from
May 7, 2019

Conversation

BrunoScheufler
Copy link
Contributor

Description

Recently I stumbled over a use case where I had to include dynamic variables in my page creation queries for Gatsby. After scanning the existing documentation for an entry, which I couldn't find, I updated the existing Gatsby Node API documentation using a variable for the entry limit and also updated the allMarkdownRemark query to use the current frontmatter instead of fields, which is no longer available on this type.

Related Issues

n/a

@BrunoScheufler BrunoScheufler requested a review from a team as a code owner May 5, 2019 08:25
@muescha
Copy link
Contributor

muescha commented May 5, 2019

@BrunoScheufler
Copy link
Contributor Author

@muescha I'd love to but I think especially for the second page that I already edited the right file as I couldn't find another one with that exact content. I'm not sure how the docs are created for those pages though, so maybe I'm missing something here 🤔

@muescha
Copy link
Contributor

muescha commented May 5, 2019

I see it is generated

Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @BrunoScheufler 👍

@sidharthachatterjee sidharthachatterjee merged commit 2ed987f into gatsbyjs:master May 7, 2019
@gatsbot
Copy link

gatsbot bot commented May 7, 2019

Holy buckets, @BrunoScheufler — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants