Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): Delete typography.js and move createGlobalStyle to separate file for styled-components example #13866

Merged
merged 2 commits into from
May 5, 2019

Conversation

jakex7
Copy link
Contributor

@jakex7 jakex7 commented May 5, 2019

Description

  • Deleted Typography.js which unnecessarily complicates the example for styled-components
  • Moved createGlobalStyle to a separate file with good practise

@jakex7 jakex7 changed the title chore(examples): Delete typography.js and move createGlobalStyle to external file for styled-components example chore(examples): Delete typography.js and move createGlobalStyle to separate file for styled-components example May 5, 2019
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jake! This seems reasonable.

@DSchau DSchau merged commit 07380e4 into gatsbyjs:master May 5, 2019
@gatsbot
Copy link

gatsbot bot commented May 5, 2019

Holy buckets, @JakeTvvv — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants