fix(gatsby-remark-responsive-iframe): Support MDX by visiting JSX nodes #13913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In MDX the nodes that need to be visited are labeled as JSX so this includes that node type in addition to HTML. Related: - mdx-js/mdx#553 - gatsbyjs#13552
DSchau
added
the
status: awaiting reviewer response
pieh
reviewed
May 17, 2019
| }) | ||
|
|
||
| expect(node).toBeDefined() | ||
| expect(node.value).toMatchSnapshot() |
There was a problem hiding this comment.
Yikes, it seems like snapshot assertion doesn't work well with testInNode8OrHigher (tests fail with 1 snapshot obsolete in node 6)
There was a problem hiding this comment.
I'll update the test to not use a snapshot 👍
pieh
removed
the
status: awaiting reviewer response
ChristopherBiscardi
approved these changes
May 25, 2019
DSchau
added
the
status: awaiting author response
freiksenet
approved these changes
Jun 24, 2019
|
Published in |
johno
added a commit
to johno/gatsby
that referenced
this pull request
Jul 17, 2019
…es (gatsbyjs#13913) In MDX the nodes that need to be visited are labeled as JSX so this includes that node type in addition to HTML. Related: - mdx-js/mdx#553 - gatsbyjs#13552
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MDX the nodes that need to be visited are labeled as JSX so this
includes that node type in addition to HTML.
Related Issues